feat: add config embedding#448
Merged
Merged
Conversation
Orzelius
commented
May 11, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds support for embedding an initial Talos machine configuration into generated schematics/images, gated behind Enterprise functionality and Talos version support, and exposes the option in the HTTP wizard UI.
Changes:
- Extend the schematic customization model to carry an embedded machine configuration string.
- Add an Enterprise
ConfigEmbedderhook and wire it through the HTTP frontend and service wiring. - Add UI wizard fields + localization for entering embedded machine config, and propagate the field into the Talos imager profile.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/schematic/schematic.go | Adds EmbeddedMachineConfiguration to schematic customization YAML model. |
| pkg/enterprise/enterprise.go | Introduces ConfigEmbedder interface in the Enterprise glue layer. |
| pkg/enterprise/enterprise_on.go | Wires enterprise implementation via NewConfigEmbedder() under enterprise build. |
| pkg/enterprise/enterprise_off.go | Returns nil embedder when enterprise is disabled. |
| enterprise/config/config_embedder.go | Implements the enterprise embedder (sets schematic embedded config). |
| internal/profile/profile.go | Propagates embedded machine config from schematic into Talos profile customization. |
| internal/frontend/http/http.go | Plumbs ConfigEmbedder into the HTTP frontend instance. |
| internal/frontend/http/ui.go | Adds wizard params, form parsing, UI gating, and schematic embedding call. |
| internal/frontend/http/templates/wizard-cmdline.html | Adds textarea for embedded machine configuration when enabled. |
| internal/frontend/http/templates/wizard-final.html | Updates back navigation params to include embedded-config selection. |
| internal/frontend/http/templates/common.html | Persists embedded-config values via hidden inputs across wizard steps. |
| internal/frontend/http/locales/active.en.yaml | Adds English strings for embedded config UI text. |
| internal/frontend/http/locales/active.fr.yaml | Adds French strings for embedded config UI text. |
| internal/frontend/http/locales/active.pl.yaml | Adds Polish strings for embedded config UI text. |
| internal/frontend/http/locales/active.ru.yaml | Adds Russian strings for embedded config UI text. |
| internal/frontend/http/css/output.css | Updates compiled Tailwind output to include new utility usage. |
| cmd/image-factory/cmd/service.go | Passes enterprise.NewConfigEmbedder() into the HTTP frontend constructor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smira
reviewed
May 11, 2026
smira
reviewed
May 11, 2026
smira
left a comment
smira
left a comment
Member
There was a problem hiding this comment.
we also need:
- docs/api.md update for new schematic field (Enterprise only note)
- integration tests, preferably based on the ones which extract initramfs to verify that embedded config gets actually embedded (I believe we already verify extensions, and this should be an extension?)
smira
reviewed
May 13, 2026
smira
left a comment
smira
left a comment
Member
There was a problem hiding this comment.
please stop pushing PRs to origin (push to your fork)
Orzelius
force-pushed
the
embedded-config
branch
14 times, most recently
from
6ead978 to
731c88c
Compare
Orzelius
changed the title
Member
Author
|
e2e test failure is unrelated |
smira
reviewed
May 21, 2026
smira
reviewed
May 21, 2026
smira
left a comment
smira
left a comment
Member
There was a problem hiding this comment.
probably also deserves a note in hack/release.toml
smira
approved these changes
May 21, 2026
frezbo
reviewed
May 21, 2026
| # optional, include well-known UEFI certificates into auto-enrollment database (SecureBoot ISO only) | ||
| includeWellKnownCertificates: true | ||
| bootloader: sd-boot # optional, defaults to auto (bootloader chosen by imager), other options: dual-boot, grub | ||
| embeddedMachineConfiguration: | # optional, embedded machine configuration (YAML-encoded) |
Member
There was a problem hiding this comment.
can we put an example of using two documents, so it's not confusing
frezbo
approved these changes
May 21, 2026
Orzelius
force-pushed
the
embedded-config
branch
3 times, most recently
from
ba9bb9d to
7bd0701
Compare
allow embedding machine configuration into Talos images. Signed-off-by: Orzelius <33936483+Orzelius@users.noreply.github.com>
Member
Author
|
/m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow embedding initial machine config for enterprise image factory.
the download integration test needed some extra work to get it running with talos 1.13